You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/26 03:38:47 UTC
[PR] Refactor CDC socket sink packages [shardingsphere]
terrymanu opened a new pull request, #40369:
URL: https://github.com/apache/shardingsphere/pull/40369
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor CDC socket sink packages [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40369:
URL: https://github.com/apache/shardingsphere/pull/40369#issuecomment-6407680510
### Result
Review Result: Mergeable
No blocking issues or recommended changes remain.
### Evidence
No stale fully qualified class names remain, and SPI loading works.
Implementation and test assertions are identical apart from package/import declarations.
### Coverage
Standalone local candidate based on 440f8086eca2, covering all 30 changed paths across the socket module, tests, and Proxy references.
Completed all three discovery lenses, convergence checks, and coordination of two independent assessments.
No unresolved differences or evidence gaps remain.
This conclusion covers code correctness only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor CDC socket sink packages [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40369:
URL: https://github.com/apache/shardingsphere/pull/40369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org