You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/01/27 15:15:46 UTC
[GitHub] [camel-quarkus] essobedo opened a new pull request, #4453: Ref #4452: Allow to disable AOT compilation of jOOR expressions
essobedo opened a new pull request, #4453:
URL: https://github.com/apache/camel-quarkus/pull/4453
fixes #4452
## Motivation
In order to give the opportunity to the end user to decide whether the compilation of jOOR expressions in JVM should be done at runtime like before or at build time, a new dedicated property configuration should be added.
## Modifications:
* Add a new configuration property called `compileAheadOfTime` for this purpose, set to `false` by default to keep the same behavior as the previous version
* Add a specific `BooleanSupplier` to enable the compilation in native mode or when `compileAheadOfTime` is `true`
* Rename the test resource `bean.joor` to `bean.txt` to avoid having to take care of the license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on pull request #4453: Ref #4452: Allow to disable build time compilation of jOOR expressions
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #4453:
URL: https://github.com/apache/camel-quarkus/pull/4453#issuecomment-1408364273
The failure is not related to this PR since it is an mail integration test that fails and it fails because of an `QuarkusBindException: Port(s) already bound: 32775: Address already in use`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4453: Ref #4452: Allow to disable AOT compilation of jOOR expressions
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4453:
URL: https://github.com/apache/camel-quarkus/pull/4453#discussion_r1090259714
##########
docs/modules/ROOT/pages/reference/extensions/joor.adoc:
##########
@@ -74,6 +74,12 @@ The specific location of the configuration of the jOOR language.
The specific default result type of an expression expressed in jOOR language.
| `string`
|
+
+|icon:lock[title=Fixed at build time] [[quarkus.camel.joor.compile-ahead-of-time]]`link:#quarkus.camel.joor.compile-ahead-of-time[quarkus.camel.joor.compile-ahead-of-time]`
Review Comment:
Wonder if `quarkus.camel.joor.compile-at-build-time` would be better? I think it's more consistent with the nomenclature that Quarkus uses (I.e AOT is rarely mentioned in docs. It's usually 'build time') .
I'm nitpicking a bit here, so happy to be ignored if you disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on a diff in pull request #4453: Ref #4452: Allow to disable AOT compilation of jOOR expressions
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #4453:
URL: https://github.com/apache/camel-quarkus/pull/4453#discussion_r1090265650
##########
docs/modules/ROOT/pages/reference/extensions/joor.adoc:
##########
@@ -74,6 +74,12 @@ The specific location of the configuration of the jOOR language.
The specific default result type of an expression expressed in jOOR language.
| `string`
|
+
+|icon:lock[title=Fixed at build time] [[quarkus.camel.joor.compile-ahead-of-time]]`link:#quarkus.camel.joor.compile-ahead-of-time[quarkus.camel.joor.compile-ahead-of-time]`
Review Comment:
👍 It makes sense indeed, let me rename it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4453: Ref #4452: Allow to disable build time compilation of jOOR expressions
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #4453:
URL: https://github.com/apache/camel-quarkus/pull/4453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org