[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #36376: GH-36352: [Python] Add project_id to GcsFileSystem options

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #36376:
URL: https://github.com/apache/arrow/pull/36376#discussion_r1246511956


##########
python/pyarrow/_gcsfs.pyx:
##########
@@ -136,6 +140,8 @@ cdef class GcsFileSystem(FileSystem):
         if retry_time_limit is not None:
             time_limit_seconds = retry_time_limit.total_seconds()
             options.retry_limit_seconds = time_limit_seconds
+        if project_id is not None:
+            options.project_id = tobytes(project_id)

Review Comment:
   ```suggestion
               options.project_id = <c_string>tobytes(project_id)
   ```
   
   Might help? (didn't test it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org