You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/02/24 11:03:21 UTC
[GitHub] flink pull request #3410: [FLINK-5772] [elasticsearch] Allow Elasticsearch 1...
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3410
[FLINK-5772] [elasticsearch] Allow Elasticsearch 1.x tests to rerun on failure
It was reported that Elasticsearch 1.x tests can fail with this exception thrown from the embedded ES node used in IT tests:
`ProcessClusterEventTimeoutException[failed to process cluster event (acquire index lock) within 1m]`.
After some googling on this, it seems like this is a potential deadlock with Elasticsearch 1.x when creating indices.
From the looks of recent Travis tests, it seems that this flakiness rarely happens, so I think retrying the tests if they fail only for Elasticsearch 1.x and not newer versions would be a simple solution.
If it happens to pop out for 2.x and 5.x also, we might need to find another solution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-5772
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3410.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3410
----
commit ac0cbeccd1958de967f762edef3bcd7a42bee830
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-02-24T10:39:46Z
[FLINK-5772] [elasticsearch] Allow Elasticsearch 1.x tests to rerun on failure
This is allowed because Elasticsearch 1.x has a potential deadlock when
creating indices. Since this flakiness rarely happens, this commit
allows rerunning the Elasticsearch 1.x tests to try to mitigate this
problem instead of just failing them.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3410: [FLINK-5772] [elasticsearch] Allow Elasticsearch 1.x test...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3410
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3410: [FLINK-5772] [elasticsearch] Allow Elasticsearch 1...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3410
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3410: [FLINK-5772] [elasticsearch] Allow Elasticsearch 1.x test...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3410
Merging to `master` ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---