You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/06 17:57:28 UTC
[GitHub] [airflow] retornam opened a new pull request #7635: [AIRFLOW-5062]
Allow ACL Header in S3Hook
retornam opened a new pull request #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635
Allow passing in the ACL header in the AWS S3 Hook
Signed-off-by: Raymond Etornam <re...@users.noreply.github.com>
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7635:
[AIRFLOW-5062] Allow ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#discussion_r390239353
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -514,9 +520,11 @@ def load_bytes(self,
:param encrypt: If True, the file will be encrypted on the server-side
by S3 and will be stored in an encrypted form while at rest in S3.
:type encrypt: bool
+ :param acl: The acess control list for the uploaded file
Review comment:
```suggestion
:param acl: The access control list for the uploaded file
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7635: [AIRFLOW-5062] Allow
ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#issuecomment-599234916
@retornam are you still working on this? Because there is also another PR #7726 which adds the same feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7635:
[AIRFLOW-5062] Allow ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#discussion_r390240401
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -687,3 +701,17 @@ def download_file(
s3_obj.download_fileobj(local_tmp_file)
return local_tmp_file.name
+
+ def get_object_permission(self,
+ bucket,
+ key):
+ """
+ :param bucket: Name of the bucker in which the object is
+ :type bucket: str
+ :param key: The key to get the object grantee permission.
+ :type key: str
+ """
Review comment:
Please add `:returns:` and `:rtype:` here. Thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7635:
[AIRFLOW-5062] Allow ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#discussion_r390239263
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -687,3 +701,17 @@ def download_file(
s3_obj.download_fileobj(local_tmp_file)
return local_tmp_file.name
+
+ def get_object_permission(self,
+ bucket,
+ key):
+ """
+ :param bucket: Name of the bucker in which the object is
Review comment:
```suggestion
:param bucket: Name of the bucket in which the object is
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle closed pull request #7635: [AIRFLOW-5062] Allow
ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle closed pull request #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7635:
[AIRFLOW-5062] Allow ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#discussion_r390240096
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -687,3 +701,17 @@ def download_file(
s3_obj.download_fileobj(local_tmp_file)
return local_tmp_file.name
+
+ def get_object_permission(self,
+ bucket,
+ key):
+ """
Review comment:
Please add a title what the function does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7635: [AIRFLOW-5062] Allow
ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#issuecomment-599448114
Duplicate. Original is https://github.com/apache/airflow/pull/7733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] retornam commented on issue #7635: [AIRFLOW-5062] Allow
ACL Header in S3Hook
Posted by GitBox <gi...@apache.org>.
retornam commented on issue #7635: [AIRFLOW-5062] Allow ACL Header in S3Hook
URL: https://github.com/apache/airflow/pull/7635#issuecomment-599243113
Yes. I’ll update the PR later today.
> On Mar 15, 2020, at 09:44, Felix Uellendall <no...@github.com> wrote:
>
>
> @retornam are you still working on this? Because there is also another PR #7726 which adds the same feature.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services