You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/18 01:32:52 UTC
[GitHub] [ozone] duongnguyen0 opened a new pull request, #3690: HDDS-6456. Update RocksDB Version to 7.x
duongnguyen0 opened a new pull request, #3690:
URL: https://github.com/apache/ozone/pull/3690
## What changes were proposed in this pull request?
This change was reverted by [HDDS-6828](https://issues.apache.org/jira/browse/HDDS-6828).
I'm checking it back in as memory leak has been fixed as per HDDS-6722
https://issues.apache.org/jira/browse/HDDS-6456
## How was this patch tested?
Standard CI. https://github.com/duongnguyen0/ozone/actions/runs/2879138807
Also ran different workloads on my local cluster and verify no leaks were generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1220909159
RocksDB team does not maintain multiple release lines and bug fixes only happen in the latest minor release.
I'd rather to update to the latest, and let it bake for a while. May need some time to catch potential problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1222620196
cc @jojochuang ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1225018950
Thanks all for the review. Merged to master branch to be included in the upcoming 1.3.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1223667476
@kerneltime @jojochuang Thanks for your feedback. I get your point. Now I also agreed to upgrade RockSDB 7 in 1.3. It needs about one or two weeks when the 1.3.0 branch be cut(because Ratis needed to upgrade), we could use this time to test RocksDB7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1221716199
@captainzmc I think we should merge this in as a blocker for 1.3. There is a pending set fault bug in the current RocksDB version and the memory leak issues were only recently addressed which allowed us to upgrade RocksDB version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1222613818
@captainzmc https://issues.apache.org/jira/browse/HDDS-5756 this was the original seg fault issue that customers are still facing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] duongnguyen0 commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
duongnguyen0 commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1224436755
Thanks @jojochuang @kerneltime @captainzmc for your reviews/suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1220928020
@duongnguyen0 before merging, we can spin up a cluster with the updated dependency and leave a mixed load running. Will sync up offline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
captainzmc commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1221733706
> There is a pending seg fault bug in the current RocksDB version
Thanks @kerneltime for the reply. Could you help to introduce the bug of RocksDB-6.29.5 that we encountered? I have confirmed with @jojochuang before, [the result of our discussion](https://issues.apache.org/jira/browse/HDDS-6722?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17577006#comment-17577006) at that time is that RocksDB7 will not be a blocker for release 1.3, this is for the stability of 1.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3690:
URL: https://github.com/apache/ozone/pull/3690#discussion_r949519999
##########
pom.xml:
##########
@@ -1630,7 +1630,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<dependency>
<groupId>org.rocksdb</groupId>
<artifactId>rocksdbjni</artifactId>
- <version>6.29.5</version>
+ <version>7.2.2</version>
Review Comment:
We should be more aggressive and try to move to https://github.com/facebook/rocksdb/releases/tag/v7.4.5
As mentioned by @jojochuang it is a good idea to go over the change log as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] duongnguyen0 commented on pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
duongnguyen0 commented on PR #3690:
URL: https://github.com/apache/ozone/pull/3690#issuecomment-1220075382
Thanks @jojochuang and @kerneltime for the review. I've gone through the [changes log of 7.4.5](https://github.com/facebook/rocksdb/compare/v7.2.2...v7.4.5) and looks like there're no breaking changes (for us). I've updated rocksdb to the latest release 7.4.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang merged pull request #3690: HDDS-6456. Update RocksDB Version to 7.x
Posted by GitBox <gi...@apache.org>.
jojochuang merged PR #3690:
URL: https://github.com/apache/ozone/pull/3690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org