You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhiwei Chen <zh...@gmail.com> on 2016/04/29 06:55:01 UTC

Review Request 46816: Fix the absolute symlink path issue of include/slave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/
-----------------------------------------------------------

Review request for mesos, zhou xing and Vinod Kone.


Repository: mesos


Description
-------

Fix the absolute symlink path issue of include/slave.


Diffs
-----

  src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 

Diff: https://reviews.apache.org/r/46816/diff/


Testing
-------

Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path.

I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build.


Thanks,

Zhiwei Chen


Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review131059
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46816]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 4:55 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> -------
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review131058
-----------------------------------------------------------



This target will not be removed until the term 'slave' is completely removed in the code, I'm ok to the change

- zhou xing


On 四月 29, 2016, 4:55 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> -----------------------------------------------------------
> 
> (Updated 四月 29, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> -------
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>