You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/20 01:13:01 UTC

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1475: [CALCITE-3371] BinaryExpression evaluate method support Mod

xy2953396112 commented on a change in pull request #1475: [CALCITE-3371] BinaryExpression evaluate method support Mod
URL: https://github.com/apache/calcite/pull/1475#discussion_r336759237
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java
 ##########
 @@ -191,6 +191,7 @@ public boolean isBangEqualAllowed() {
 
   @Override public boolean isPercentRemainderAllowed() {
     switch (this) {
+    case DEFAULT:
     case BABEL:
 
 Review comment:
   changed the default behavior of % in SQL in order to valide end-to-end IT case in JdbcTest.it may be allowed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services