You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/04 17:07:27 UTC
[GitHub] [camel-website] rimshach opened a new pull request #315: Fix drop
down menu overlap issue on small screens
rimshach opened a new pull request #315: Fix drop down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315
On smaller screens ,the dropdown menu headings overlapped each other,making navigation difficult.
Now this looks like this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609064710
@zregvart I think when you made your PR #306, you didn't realise that you're putting common CSS for all media screens. I don't think the menu on the small screen should be having the box outline, or the hover effect - those were only for >1024px screens... I think we'll need to bring back the CSS for small media screens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] rimshach commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
rimshach commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609799289
Oh I did'nt see your pull request before but if you have done then that's great,Thankyou :)No it's fine let's go with the PR you created.I'll close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] rimshach edited a comment on issue #315: Fix
drop-down menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
rimshach edited a comment on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609712534
If this is already been done as @aashnajena mentioned and css was not merged then i'll close the pull request or if this requires css for <1024 and this is how it should be fixed then i'll do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609659680
This is what we have currently at 1024px:
Firefox/Chromium:
This is what we have with this PR (Firefox/Chromium:
At 1023px and lower, the top level navigation is removed and hamburger menu on the top right is shown.
Not sure what the issue is or how this solves it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] rimshach closed pull request #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
rimshach closed pull request #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609663831
The issue seems to be with mobile menus. Here's how it looks on the current website on my phone :
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609694175
Ah, okay, now I see. So we need a solution here for both cases, this one breaks the >1024px width case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] rimshach commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
rimshach commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609712534
If this is already been done as @aashnajena mentioned and css was not merged then i'll close the pull request or if this requires css for <1023 and this is how it should be fixed then i'll do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #315: Fix
drop-down menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609663831
The issue seems to be with mobile menus. Here's how it looks on my phone:
What this PR does is not enough, I think we need specific CSS for smaller screens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #315: Fix drop-down
menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609779573
@rimshach I have actually worked on this menu before so I think I understand exactly where the problem is. I've made some changes at #328 which should fix the issues for all screen sizes. You can test them and include them here if you want..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #315: Fix
drop-down menu overlap issue on small screens
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #315: Fix drop-down menu overlap issue on small screens
URL: https://github.com/apache/camel-website/pull/315#issuecomment-609064710
@zregvart I think when you made your PR #306, you didn't realise that you're putting common CSS for all media screens. I don't think you intended the menu on the small screen to be having the box outline, or the hover effect - those were only for >1024px screens... We'll need to bring back the CSS for small media screens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services