You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/11/05 17:32:42 UTC

[GitHub] [lucenenet] NightOwl888 opened a new pull request, #743: Fixed constructors of abstract classes according to SonarCloud recommendations (fixes #677)

NightOwl888 opened a new pull request, #743:
URL: https://github.com/apache/lucenenet/pull/743

   Fixes #667.
   
   On all abstract classes:
   
   - Changed public constructors to protected
   - Changed internal constructors to private protected
   - Changed protected internal constructors to protected (SonarCloud gave [incorrect advice](https://github.com/apache/lucenenet/issues/648#issuecomment-1299606844) to make them private protected)
   
   - **BREAKING:**  `Lucene.Net.Search.FieldCacheRangeFilter<T>`: Changed accessibility from protected internal to private protected. This class was not intended to be subclassed by users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [lucenenet] NightOwl888 merged pull request #743: Fixed constructors of abstract classes according to SonarCloud recommendations (fixes #677)

Posted by GitBox <gi...@apache.org>.
NightOwl888 merged PR #743:
URL: https://github.com/apache/lucenenet/pull/743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org