You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by an...@apache.org on 2008/10/15 11:31:07 UTC
svn commit: r704822 - in /tuscany/java/sca/modules/binding-jms-runtime/src:
main/java/org/apache/tuscany/sca/binding/jms/provider/
test/java/org/apache/tuscany/sca/binding/jms/
Author: antelder
Date: Wed Oct 15 02:31:06 2008
New Revision: 704822
URL: http://svn.apache.org/viewvc?rev=704822&view=rev
Log:
Create JMSResourceFactory interface in preperation for making it plugable
Modified:
tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingInvoker.java
tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingListener.java
tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingReferenceBindingProvider.java
tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java
tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSResourceFactoryImpl.java
tuscany/java/sca/modules/binding-jms-runtime/src/test/java/org/apache/tuscany/sca/binding/jms/OperationSelectionTestCaseFIXME.java
Modified: tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingInvoker.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingInvoker.java?rev=704822&r1=704821&r2=704822&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingInvoker.java (original)
+++ tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingInvoker.java Wed Oct 15 02:31:06 2008
@@ -61,7 +61,7 @@
protected String operationName;
protected JMSBinding jmsBinding;
- protected JMSResourceFactoryImpl jmsResourceFactory;
+ protected JMSResourceFactory jmsResourceFactory;
protected JMSMessageProcessor requestMessageProcessor;
protected JMSMessageProcessor responseMessageProcessor;
protected Destination bindingRequestDest;
@@ -70,7 +70,7 @@
protected JMSTokenAuthenticationPolicy jmsTokenAuthenticationPolicy = null;
protected JMSHeaderPolicy jmsHeaderPolicy = null;
- public JMSBindingInvoker(JMSBinding jmsBinding, Operation operation, JMSResourceFactoryImpl jmsResourceFactory, RuntimeComponentReference reference) {
+ public JMSBindingInvoker(JMSBinding jmsBinding, Operation operation, JMSResourceFactory jmsResourceFactory, RuntimeComponentReference reference) {
this.operation = operation;
operationName = operation.getName();
Modified: tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingListener.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingListener.java?rev=704822&r1=704821&r2=704822&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingListener.java (original)
+++ tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingListener.java Wed Oct 15 02:31:06 2008
@@ -62,7 +62,7 @@
private static final String ON_MESSAGE_METHOD_NAME = "onMessage";
private JMSBinding jmsBinding;
private Binding targetBinding;
- private JMSResourceFactoryImpl jmsResourceFactory;
+ private JMSResourceFactory jmsResourceFactory;
private RuntimeComponentService service;
private JMSMessageProcessor requestMessageProcessor;
private JMSMessageProcessor responseMessageProcessor;
@@ -70,7 +70,7 @@
private List<Operation> serviceOperations;
protected JMSTokenAuthenticationPolicy jmsTokenAuthenticationPolicy = null;
- public JMSBindingListener(JMSBinding jmsBinding, JMSResourceFactoryImpl jmsResourceFactory, RuntimeComponentService service, Binding targetBinding) throws NamingException {
+ public JMSBindingListener(JMSBinding jmsBinding, JMSResourceFactory jmsResourceFactory, RuntimeComponentService service, Binding targetBinding) throws NamingException {
this.jmsBinding = jmsBinding;
this.jmsResourceFactory = jmsResourceFactory;
this.service = service;
Modified: tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingReferenceBindingProvider.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingReferenceBindingProvider.java?rev=704822&r1=704821&r2=704822&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingReferenceBindingProvider.java (original)
+++ tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingReferenceBindingProvider.java Wed Oct 15 02:31:06 2008
@@ -49,7 +49,7 @@
private RuntimeComponentReference reference;
private JMSBinding jmsBinding;
private List<JMSBindingInvoker> jmsBindingInvokers = new ArrayList<JMSBindingInvoker>();
- private JMSResourceFactoryImpl jmsResourceFactory;
+ private JMSResourceFactory jmsResourceFactory;
private RuntimeComponent component;
private InterfaceContract wsdlInterfaceContract;
private ExtensionPointRegistry extensions;
Modified: tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java?rev=704822&r1=704821&r2=704822&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java (original)
+++ tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java Wed Oct 15 02:31:06 2008
@@ -57,7 +57,7 @@
private RuntimeComponentService service;
private Binding targetBinding;
private JMSBinding jmsBinding;
- private JMSResourceFactoryImpl jmsResourceFactory;
+ private JMSResourceFactory jmsResourceFactory;
private MessageConsumer consumer;
private WorkScheduler workScheduler;
private boolean running;
Modified: tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSResourceFactoryImpl.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSResourceFactoryImpl.java?rev=704822&r1=704821&r2=704822&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSResourceFactoryImpl.java (original)
+++ tuscany/java/sca/modules/binding-jms-runtime/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSResourceFactoryImpl.java Wed Oct 15 02:31:06 2008
@@ -37,7 +37,7 @@
*
* @version $Rev$ $Date$
*/
-public class JMSResourceFactoryImpl {
+public class JMSResourceFactoryImpl implements JMSResourceFactory {
private String initialContextFactoryName;
private String connectionFactoryName = "ConnectionFactory";
@@ -64,7 +64,7 @@
* able to leverage the host environment to provide connection pooling if it can. E.g. if Tuscany is running inside
* an AppServer Then we could leverage the JMS resources it provides
*
- * @see org.apache.tuscany.binding.jms.JMSResourceFactory#getConnection()
+ * @see org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory#getConnection()
*/
public Connection getConnection() throws NamingException, JMSException {
if (connection == null) {
@@ -76,7 +76,7 @@
/*
* (non-Javadoc)
*
- * @see org.apache.tuscany.binding.jms.JMSResourceFactory#createSession()
+ * @see org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory#createSession()
*/
public Session createSession() throws JMSException, NamingException {
return getConnection().createSession(false, Session.AUTO_ACKNOWLEDGE);
@@ -85,7 +85,7 @@
/*
* (non-Javadoc)
*
- * @see org.apache.tuscany.binding.jms.JMSResourceFactory#startConnection()
+ * @see org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory#startConnection()
*/
public void startConnection() throws JMSException, NamingException {
if (!isConnectionStarted) {
@@ -97,7 +97,7 @@
/*
* (non-Javadoc)
*
- * @see org.apache.tuscany.binding.jms.JMSResourceFactory#closeConnection()
+ * @see org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory#closeConnection()
*/
public void closeConnection() throws JMSException {
if (connection != null) {
@@ -154,6 +154,9 @@
}
}
+ /* (non-Javadoc)
+ * @see org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory#lookupDestination(java.lang.String)
+ */
public Destination lookupDestination(String destName) throws NamingException {
if (JMSBindingConstants.DEFAULT_DESTINATION_NAME.equals(destName)) {
return null;
@@ -194,8 +197,8 @@
return null;
}
- /**
- * You can create a destination in ActiveMQ (and have it appear in JNDI) by putting "dynamicQueues/" in front of the queue name being looked up
+ /* (non-Javadoc)
+ * @see org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory#createDestination(java.lang.String)
*/
public Destination createDestination(String jndiName) throws NamingException {
return lookupDestination("dynamicQueues/" + jndiName);
Modified: tuscany/java/sca/modules/binding-jms-runtime/src/test/java/org/apache/tuscany/sca/binding/jms/OperationSelectionTestCaseFIXME.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/binding-jms-runtime/src/test/java/org/apache/tuscany/sca/binding/jms/OperationSelectionTestCaseFIXME.java?rev=704822&r1=704821&r2=704822&view=diff
==============================================================================
--- tuscany/java/sca/modules/binding-jms-runtime/src/test/java/org/apache/tuscany/sca/binding/jms/OperationSelectionTestCaseFIXME.java (original)
+++ tuscany/java/sca/modules/binding-jms-runtime/src/test/java/org/apache/tuscany/sca/binding/jms/OperationSelectionTestCaseFIXME.java Wed Oct 15 02:31:06 2008
@@ -25,7 +25,7 @@
import org.apache.tuscany.sca.binding.jms.impl.JMSBinding;
import org.apache.tuscany.sca.binding.jms.provider.JMSBindingListener;
-import org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactoryImpl;
+import org.apache.tuscany.sca.binding.jms.provider.JMSResourceFactory;
import org.apache.tuscany.sca.interfacedef.Interface;
import org.apache.tuscany.sca.interfacedef.InterfaceContract;
import org.apache.tuscany.sca.interfacedef.Operation;
@@ -181,7 +181,7 @@
throws Exception {
// Create the test JMS Binding
final JMSBinding jmsBinding = new JMSBinding();
- JMSResourceFactoryImpl jmsResourceFactory = null;
+ JMSResourceFactory jmsResourceFactory = null;
// Extra information for the method we are invoking
final String operationParams = "Hello";