You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/10/25 12:23:02 UTC

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1265: Sensor feeds tidy

ahgittin commented on a change in pull request #1265:
URL: https://github.com/apache/brooklyn-server/pull/1265#discussion_r735544891



##########
File path: core/src/main/java/org/apache/brooklyn/util/core/task/ScheduledTask.java
##########
@@ -231,10 +231,12 @@ protected String getActiveTaskStatusString(int verbosity) {
     
     @Override
     public boolean isDone(boolean andTaskNoLongerRunning) {
+        boolean done = isCancelled() || (maxIterations!=null && maxIterations <= runCount) || (period==null && nextRun!=null && nextRun.isDone());

Review comment:
       i think you are right, will update




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org