You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by "Hari Shreedharan (JIRA)" <ji...@apache.org> on 2014/09/12 19:56:34 UTC

[jira] [Commented] (FLUME-2420) HDFSEventSink#stop might throw ConcurrentModificationException

    [ https://issues.apache.org/jira/browse/FLUME-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131835#comment-14131835 ] 

Hari Shreedharan commented on FLUME-2420:
-----------------------------------------

+1. Committing this after running tests. I added a synchronized block around the clear call at the end of stop as well to fix possible contention with other threads.

> HDFSEventSink#stop might throw ConcurrentModificationException
> --------------------------------------------------------------
>
>                 Key: FLUME-2420
>                 URL: https://issues.apache.org/jira/browse/FLUME-2420
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.5.0
>            Reporter: chenshangan
>            Assignee: chenshangan
>         Attachments: FLUME-2420.patch
>
>
> There's a chance that bucketWriter callback and HDFSEventSink#stop operate on sfWriter together. So synchronized should apply before operation on sfWriter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)