You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "extinguish (via GitHub)" <gi...@apache.org> on 2024/09/26 06:59:41 UTC
[PR] fix the misra check issues [nuttx]
extinguish opened a new pull request, #13629:
URL: https://github.com/apache/nuttx/pull/13629
## Summary
1. fix the moblib_bind variable uninit misra issue
2. remove the unreached dead code in pthread_mutexattr_setprotocol
3. fix using the uninit value misra issue in hcreate
4. fix the ret value not check erro on fs_fcntl
## Impact
## Testing
1. has pass the ostest
5. has checked on ghs and gcc compiler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the misra check issues [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13629:
URL: https://github.com/apache/nuttx/pull/13629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix the misra check issues [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13629:
URL: https://github.com/apache/nuttx/pull/13629#issuecomment-2376156849
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This PR summary is insufficient and it does not meet the NuttX Requirements. Here's why and how to fix it:
**What's Missing & How to Fix It:**
* **Summary:**
* **Be Specific:** Instead of just stating "fix the moblib_bind variable uninit misra issue," explain what moblib_bind is, where it's used, and why initializing it is important. For example: "Fixes an uninitialized variable issue in the moblib_bind function used by [explain functionality]. This uninitialized variable could lead to unpredictable behavior during [explain scenario]."
* **Provide Context for Each Change:** Do this for ALL listed changes (dead code removal, hcreate issue, fs_fcntl issue, etc.). Explain the potential consequences of the original bugs.
* **Issue References:** If these fixes address specific issues, include the issue numbers (e.g., "Fixes #1234").
* **Impact:**
* **You must address each impact category:** Even if the answer is "NO", state it explicitly (e.g., "Impact on build: NO").
* **Provide Details When Applicable:** For example, if a change impacts a specific architecture (like ARM), mention it.
* **User Impact is Crucial:** If any change affects how users interact with NuttX, this section needs a detailed explanation.
* **Testing:**
* **Insufficient Information:**
* **Build Hosts:** Specify the exact operating systems and versions used for testing (e.g., "Ubuntu 20.04," "macOS 12.4").
* **Target(s):** Provide the full architecture and board configurations. For example, "sim:qemu-arm" or "ARM:STM32F4 Discovery board".
* **Testing Logs:** The logs you've provided are placeholders. Include the *actual* relevant log output from your tests, both before and after the changes.
* **Test Cases:** Briefly describe the specific tests you ran to verify the changes (e.g., "Ran network tests to confirm moblib_bind fix," "Performed file system stress tests").
**Example of an Improved Summary Point:**
Instead of:
> 1. fix the moblib_bind variable uninit misra issue
Write something like:
> 1. **Fixes an uninitialized variable issue in the `moblib_bind` function, which is responsible for [explain function's purpose, e.g., binding network sockets to specific interfaces]. Leaving this variable uninitialized could lead to non-deterministic behavior, potentially causing network connectivity failures in certain scenarios. This addresses issue #[issue number, if applicable].**
**Remember:** A good PR description is crucial for reviewers to understand your changes, assess their impact, and confidently merge them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org