You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2015/11/01 01:37:36 UTC

[GitHub] spark pull request: [SPARK-9858][SPARK-9859][SPARK-9861][SQL] Add ...

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9276#discussion_r43577777
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
    @@ -129,8 +143,29 @@ case class Exchange(newPartitioning: Partitioning, child: SparkPlan) extends Una
         }
       }
     
    -  protected override def doExecute(): RDD[InternalRow] = attachTree(this , "execute") {
    +  override protected def doPrepare(): Unit = {
    +    // If an ExchangeCoordinator is needed, we register this Exchange operator
    +    // to the coordinator when we do prepare. It is important to make sure
    +    // we register this operator right before the execution instead of register it
    +    // in the constructor.
    --- End diff --
    
    Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org