[GitHub] [incubator-datasketches-cpp] jmalkin commented on pull request #161: Fix vector_of_kll_sketches check for number of elements

[GitBox <gi...@apache.org>]

jmalkin commented on pull request #161:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/161#issuecomment-650438808


   Looks good. Should probably have a unit test that tests 1-d, 2-d, and some failure case. I'll try to add that if you don't get to it first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org