You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/07 01:37:41 UTC

[GitHub] [geode] demery-pivotal opened a new pull request #7246: GEODE-9924: Avoid merging repeat test logs

demery-pivotal opened a new pull request #7246:
URL: https://github.com/apache/geode/pull/7246


   PROBLEM
   
   Our repeat test tasks merge the output from all executions of a given
   test class, making it very difficult to diagnose failures in repeat
   tests.
   
   CAUSE
   
   In order to run tests repeatedly, our repeat test tasks override Gradle
   code to allow a test class to execute more than once. Gradle's test
   reporting code does not expect this. It directs the output from each
   test to a log associated with the test class name, not with the specific
   execution of the test class. This results in merging the outputs from
   different executions of the same class.
   
   SOLUTION
   
   Change Gradle to distinguish separate executions of a test class, and to
   log the output from each execution separately.
   
   Components:
   - New `ExecutionTrackingTestResultProcessor` class: Wraps a given test
     result processor to append an execution identifier (a simple counter)
     to the name of the test class when reporting results. Gradle
     associates the output with this execution-specific name instead of
     with the class name.
   - New `ExecutionTrackingTestClassProcessor` class: Wraps a given test
     class processor to report via an
     `ExecutionTrackingTestResultProcessor`.
   - Change `RepeatTestExecuter` to use an
     `ExecutionTrackingTestClassProcessor`.
   
   This commit also reverts GEODE-9912, which partially addressed the same
   problem by adding an execution ID to each log line from a DUnit ChildVM.
   The execution ID made it possible to identify the source of each merged
   log line. GEODE-9924 (this commit) makes the changes from GEODE-9912
   unnecessary.
   
   NOTES
   - Gradle now creates distinct XML and HTML report files for each
     execution of a given test class.
   - The test summary HTML page created by Gradle lists each test class
     execution separately. If a class named `FooTest` executes 50 times (as
     in a stress test run), the summary will list `FooTest-01`,
     `FooTest-02`, ..., `FooTest-50` as if they were separate test classes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #7246: GEODE-9924: Avoid merging repeat test logs

Posted by GitBox <gi...@apache.org>.
demery-pivotal commented on pull request #7246:
URL: https://github.com/apache/geode/pull/7246#issuecomment-1007644180


   I've put this PR back into DRAFT mode. I need to handle JUnit 5 nested test classes better. I want to make sure that all of the classes that run in the same processor (the outermost class and all of its nested classes) get the same execution ID.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal merged pull request #7246: GEODE-9924: Avoid merging repeat test logs

Posted by GitBox <gi...@apache.org>.
demery-pivotal merged pull request #7246:
URL: https://github.com/apache/geode/pull/7246


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal edited a comment on pull request #7246: GEODE-9924: Avoid merging repeat test logs

Posted by GitBox <gi...@apache.org>.
demery-pivotal edited a comment on pull request #7246:
URL: https://github.com/apache/geode/pull/7246#issuecomment-1007842296


   I've addressed the JUnit 5 nested class issue. The PR is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #7246: GEODE-9924: Avoid merging repeat test logs

Posted by GitBox <gi...@apache.org>.
demery-pivotal commented on pull request #7246:
URL: https://github.com/apache/geode/pull/7246#issuecomment-1007842296


   I've addressed the JUnit 5 nested class issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal edited a comment on pull request #7246: GEODE-9924: Avoid merging repeat test logs

Posted by GitBox <gi...@apache.org>.
demery-pivotal edited a comment on pull request #7246:
URL: https://github.com/apache/geode/pull/7246#issuecomment-1007842296


   I've addressed the JUnit 5 nested class issue. The PR is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #7246: GEODE-9924: Avoid merging repeat test logs

Posted by GitBox <gi...@apache.org>.
demery-pivotal commented on pull request #7246:
URL: https://github.com/apache/geode/pull/7246#issuecomment-1007644180






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org