You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/10 07:49:04 UTC
[GitHub] [incubator-nuttx] michallenc commented on a change in pull request #4506: LCD: Merge files for ST7735 and ST7789 into ST77XX
michallenc commented on a change in pull request #4506:
URL: https://github.com/apache/incubator-nuttx/pull/4506#discussion_r705970889
##########
File path: drivers/lcd/Kconfig
##########
@@ -619,15 +625,15 @@ if LCD_ST7789
---help---
Specifies the Y offset of the LCD.
- config LCD_ST7789_BPP
+ config LCD_ST77XX_BPP
Review comment:
Hi @gustavonihei I´ve just tried enabling both ST7735 and ST7789 and it configured and compiled NuttX without any problems. But when I run the fb example application it took the resolution of ST7735 instead of ST7789 because of those #ifdefs https://github.com/michallenc/incubator-nuttx/blob/st77xx/drivers/lcd/st77xx.c#L97.
I think the changes I did would not allow to use both 7735 and 7789 at the same time (because of resolution and also some other stuffs that are under ifdefs). It is a question whether we want to keep that option of using both controllers (I don´t know how much are two different displays used, haven´t seen much of those options myself) or to keep those controllers under one file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org