You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/24 16:02:52 UTC
[GitHub] [hudi] bvaradar opened a new pull request #1765: [HUDI-1049] In inline compaction mode, previously failed compactions needs to be retried before new compactions
bvaradar opened a new pull request #1765:
URL: https://github.com/apache/hudi/pull/1765
This is a patch in 0.5.3 to unblock user noticing this issue - [HUDI-1049] In inline compaction mode, previously failed compactions needs to be retried before new compactions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1765:
URL: https://github.com/apache/hudi/pull/1765#issuecomment-660563449
@zuyanton .I am going to rebase this onto master and then land for 0.6.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zuyanton commented on pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
zuyanton commented on pull request #1765:
URL: https://github.com/apache/hudi/pull/1765#issuecomment-651199789
I was running this bug fix on two large tables updated every 10 minutes for 3 days. I don't see any lingering compactions that are INFLIGHT mode. also ran this code change on old table that already had several compactions stuck INFLIGHT, verified that lingering INFLIGHT compaction were restarted successfully
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1765:
URL: https://github.com/apache/hudi/pull/1765#issuecomment-662094985
Closing this in favor of #1857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1765:
URL: https://github.com/apache/hudi/pull/1765#discussion_r445214053
##########
File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java
##########
@@ -1147,6 +1148,18 @@ private HoodieCommitMetadata doCompactionCommit(HoodieTable<T> table, JavaRDD<Wr
return metadata;
}
+ private void runEarlierInflightCompactions(HoodieTable<T> table) {
Review comment:
can we add a test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zuyanton commented on pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
zuyanton commented on pull request #1765:
URL: https://github.com/apache/hudi/pull/1765#issuecomment-659833939
any updates ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar closed pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
vinothchandar closed pull request #1765:
URL: https://github.com/apache/hudi/pull/1765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1765: [HUDI-1049] 0.5.3 Patch - In inline compaction mode, previously failed compactions needs to be retried before new compactions
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1765:
URL: https://github.com/apache/hudi/pull/1765#issuecomment-651719069
@zuyanton This is great.. Thanks for testing it out.. We will work on getting this landed onto master first..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org