You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2026/10/16 01:24:02 UTC
[PR] Correctly skip read_gbq tests when apitools is unavailable [beam]
shunping opened a new pull request, #40623:
URL: https://github.com/apache/beam/pull/40623
Two tests in `apache_beam/dataframe/io_test.py` started failing in the non-GCP `py3xx` tox environments:
- `ReadGbqTransformTests.test_bad_schema_public_api_direct_read`: `ValueError: Please install GCP Dependencies.`
- `ReadGbqTransformTests.test_unsupported_callable`: the expected "got a callable instead" error never appeared. Instead it raised
`TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union`.
**Root cause**
- `ReadGbqTransformTests` was skipped only when `google.api_core` could not be imported. The tests actually need the apitools-based BigQuery client (`apache_beam.io.gcp.internal.clients.bigquery`).
- `cloud-sql-python-connector` 1.23.0, released 2026-10-15 and pulled in by the `test` extra, adds a new dependency on `google-cloud-sql`, which needs `google-api-core`. So `google.api_core` is now installed in the non-GCP envs, but `google-apitools` is not.
As a result:
- the test class is no longer skipped
- the BigQuery client module imports but is empty, because its `__init__.py` swallows the `ImportError`. So `bigquery.TableFieldSchema` doesn't exist.
- `bigquery_tools.TableReference` falls back to `None`, so `parse_table_reference` ends up calling `isinstance(table, None)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python unit tests broken by google-api-core arriving via cloud-sql-python-connector 1.23.0 [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40623:
URL: https://github.com/apache/beam/pull/40623#issuecomment-6208428879
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40623?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.92%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`991b804`](https://app.codecov.io/gh/apache/beam/commit/991b8044342f203be44de983f55b60407a33ae35?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 200 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40623 +/- ##
=============================================
+ Coverage 56.16% 79.92% +23.75%
=============================================
Files 1124 488 -636
Lines 178336 82550 -95786
Branches 1489 0 -1489
=============================================
- Hits 100170 65978 -34192
+ Misses 75645 16572 -59073
+ Partials 2521 0 -2521
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/40623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java](https://app.codecov.io/gh/apache/beam/pull/40623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/beam/pull/40623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.92% <100.00%> (+0.36%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40623?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correctly skip read_gbq tests when apitools is unavailable [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #40623:
URL: https://github.com/apache/beam/pull/40623#issuecomment-6205988963
cc'ed @Amar3tto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Python unit tests broken by google-api-core arriving via cloud-sql-python-connector 1.23.0 [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #40623:
URL: https://github.com/apache/beam/pull/40623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org