You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2017/02/03 06:39:52 UTC

[jira] [Updated] (SOLR-6246) Core fails to reload when AnalyzingInfixSuggester is used as a Suggester

     [ https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Rowe updated SOLR-6246:
-----------------------------
    Attachment: SOLR-6246.patch

I think suggester builds interrupted by core reload or shutdown should fail gracefully (rather than hold up reload/shutdown).

This patch:

# Cleans up the previously described tests.
# Changes {{SolrSuggester.build()}} to throw {{SolrCoreState.CoreIsClosedException}} with a descriptive message when {{AlreadyClosedException}} is thrown during suggester build due to a closed {{IndexWriter}} (the result of calling {{close()}} on the suggester as part of a core reload or shutdown).
# Tests for reload & shutdown during suggester build look for the appropriate wrapped exception.
# New {{expectThrows()}} variant added to {{LuceneTestCase}} that checks for both expected outer and wrapped exceptions.

I think it's ready.

> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
>                 Key: SOLR-6246
>                 URL: https://issues.apache.org/jira/browse/SOLR-6246
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SearchComponents - other
>    Affects Versions: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
>            Reporter: Varun Thacker
>         Attachments: SOLR-6246.patch, SOLR-6246.patch, SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to AnalyzingInfixSuggester. One of the changes that went in was a writer is persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester is created. When trying to create a new writer on the same Directory a lock cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a reloadHook where we close the writer?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org