You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/10/24 20:22:33 UTC
Review Request 27150: Reordered functions in type_utils and added an
equal comparator for Volume.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27150/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
I've reordered the functions (grouped by operator type, sorted by alphebet, moved non-trivial functions to cpp file). I haven't changed any content.
Also, I added a equal comparator for Volume.
Diffs
-----
src/common/type_utils.hpp f10b2d31f2781bd056898f93eb8e8b6d9809e80b
src/common/type_utils.cpp 4f8d6ec912a41d11f16970ef7bbfa72bcbef8e8b
Diff: https://reviews.apache.org/r/27150/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 27150: Reordered functions in type_utils and added
an equal comparator for Volume.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27150/#review58328
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27150]
All tests passed.
- Mesos ReviewBot
On Oct. 24, 2014, 6:22 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27150/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 6:22 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I've reordered the functions (grouped by operator type, sorted by alphebet, moved non-trivial functions to cpp file). I haven't changed any content.
>
> Also, I added a equal comparator for Volume.
>
>
> Diffs
> -----
>
> src/common/type_utils.hpp f10b2d31f2781bd056898f93eb8e8b6d9809e80b
> src/common/type_utils.cpp 4f8d6ec912a41d11f16970ef7bbfa72bcbef8e8b
>
> Diff: https://reviews.apache.org/r/27150/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 27150: Reordered functions in type_utils and added
an equal comparator for Volume.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27150/#review58329
-----------------------------------------------------------
Ship it!
src/common/type_utils.hpp
<https://reviews.apache.org/r/27150/#comment99281>
Why did you wrap all the ones above but not this one?
- Ben Mahler
On Oct. 24, 2014, 6:22 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27150/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 6:22 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I've reordered the functions (grouped by operator type, sorted by alphebet, moved non-trivial functions to cpp file). I haven't changed any content.
>
> Also, I added a equal comparator for Volume.
>
>
> Diffs
> -----
>
> src/common/type_utils.hpp f10b2d31f2781bd056898f93eb8e8b6d9809e80b
> src/common/type_utils.cpp 4f8d6ec912a41d11f16970ef7bbfa72bcbef8e8b
>
> Diff: https://reviews.apache.org/r/27150/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>