[GitHub] [spark] gengliangwang edited a comment on issue #24806: [WIP][SPARK-27856][SQL] Only allow type upcasting when inserting table

[GitBox <gi...@apache.org>]

gengliangwang edited a comment on issue #24806: [WIP][SPARK-27856][SQL] Only allow type upcasting when inserting table
URL: https://github.com/apache/spark/pull/24806#issuecomment-501189948
 
 
   As discussed in https://github.com/apache/spark/pull/24849 , we can't upcast decimal to double/float. 
   I think we might have to close this one. Then, we can't do the upcasting either in V2 write path.
   
   Or, we can match the case of converting decimal to double/float in [DataType.canWrite](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala#L368). 
   
   There can be other solutions. What do you think? @cloud-fan @rdblue @gatorsmile 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org