[GitHub] [royale-compiler] greg-dove commented on issue #93: Change to XML.children() is non-conforming/breaks tests

[GitBox <gi...@apache.org>]

greg-dove commented on issue #93: Change to XML.children() is non-conforming/breaks tests
URL: https://github.com/apache/royale-compiler/issues/93#issuecomment-516705365
 
 
   It's pretty hard to manage any of this unless we use the unit tests. We need something that is methodically managed, because it's too complex to verify 'breaking' behavior via adhoc testing, and we'll keep taking one step back as we take another step forward elsewhere. 
   I can't consider anything I did as 'breaking' when there is not yet test coverage for that. We need to keep adding tests. If you see something I do that 'breaks' something that is not covered, please feel free to call me out on it... or better still add a failing test, and I will address it. I realise it will be easier once these tests are ported to RoyaleUnit because then it will break the build if something is not right, so I will try to get there next week.  Meanwhile if you can give me a simple example of something that was not working right with XML.children(), I will take a look tomorrow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services