You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/11 15:08:56 UTC
[GitHub] [iceberg] samredai opened a new pull request, #5246: Add Makefile argument to pass-through args to pytest
samredai opened a new pull request, #5246:
URL: https://github.com/apache/iceberg/pull/5246
This adds a `PYTEST_ARGS` argument to the `make test` command. This allows you to add arguments that Make will pass through to pytest. For example you can do `make test PYTEST_ARGS="-v"` to get verbose output, or `make test PYTEST_ARGS="--pdb"` to launch the pdb debugger on a failed test.
cc: @Fokko @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dramaticlly commented on a diff in pull request #5246: Add Makefile argument to pass-through args to pytest
Posted by GitBox <gi...@apache.org>.
dramaticlly commented on code in PR #5246:
URL: https://github.com/apache/iceberg/pull/5246#discussion_r918156567
##########
python/CONTRIBUTING.md:
##########
@@ -71,3 +71,15 @@ For Python, we use pytest in combination with coverage to maintain 90% code cove
```bash
make test
```
+
+To pass additional arguments to pytest, you can use `PYTEST_ARGS`.
Review Comment:
Even better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5246: Add Makefile argument to pass-through args to pytest
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5246:
URL: https://github.com/apache/iceberg/pull/5246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dramaticlly commented on a diff in pull request #5246: Add Makefile argument to pass-through args to pytest
Posted by GitBox <gi...@apache.org>.
dramaticlly commented on code in PR #5246:
URL: https://github.com/apache/iceberg/pull/5246#discussion_r918146053
##########
python/CONTRIBUTING.md:
##########
@@ -71,3 +71,15 @@ For Python, we use pytest in combination with coverage to maintain 90% code cove
```bash
make test
```
+
+To pass additional arguments to pytest, you can use `PYTEST_ARGS`.
Review Comment:
not sure if it would help, but one can discover list of potential arguments from https://docs.pytest.org/en/7.1.x/reference/reference.html#id89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #5246: Add Makefile argument to pass-through args to pytest
Posted by GitBox <gi...@apache.org>.
samredai commented on PR #5246:
URL: https://github.com/apache/iceberg/pull/5246#issuecomment-1180543845
Great idea @Fokko, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a diff in pull request #5246: Add Makefile argument to pass-through args to pytest
Posted by GitBox <gi...@apache.org>.
samredai commented on code in PR #5246:
URL: https://github.com/apache/iceberg/pull/5246#discussion_r918155166
##########
python/CONTRIBUTING.md:
##########
@@ -71,3 +71,15 @@ For Python, we use pytest in combination with coverage to maintain 90% code cove
```bash
make test
```
+
+To pass additional arguments to pytest, you can use `PYTEST_ARGS`.
Review Comment:
I tried just adding a `--help` pass-through arg and it worked so I added this line to the contributing docs:
> To see all available pytest arguments, run `make test PYTEST_ARGS="--help"`.
Thanks @dramaticlly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org