You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ddebowczyk92 (via GitHub)" <gi...@apache.org> on 2023/08/31 14:54:34 UTC
[GitHub] [beam] ddebowczyk92 opened a new pull request, #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
ddebowczyk92 opened a new pull request, #28262:
URL: https://github.com/apache/beam/pull/28262
…than 1ms in FlinkDetachedRunnerResult
This PR addresses issue #28258. If the provided `duration` value will be less than 1ms, the `while` loop condition will be always `True`
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1729062261
OK. LGTM, @ddebowczyk92 thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1727936357
I'm not even sure why its getting run actually, looks like it is known flaky and we've tried to ignore it previously - #27555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1725779121
Run Java_PVR_Flink_Batch PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1701389459
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1703788141
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ddebowczyk92 commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "ddebowczyk92 (via GitHub)" <gi...@apache.org>.
ddebowczyk92 commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1703787874
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1725691401
@je-ik would you mind taking a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik merged pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik merged PR #28262:
URL: https://github.com/apache/beam/pull/28262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1727126202
The change LGTM, failing check seems not related, but I'd like to see the precommit pass. @damccorm do you see why the dataflow check fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1727933997
I am not sure, looks like there are some intermittent flakes with the suite though. This change is almost definitely not the culprit, so I'd lean towards us just filing an issue for testMaxThreadMetric and not blocking the PR. I also kicked it again to see if we can get a green run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1717510460
Reminder, please take a look at this pr: @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28262: [runners-flink] #28258 Wait infinitely if the duration value is less …
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28262:
URL: https://github.com/apache/beam/pull/28262#issuecomment-1721176305
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org