You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "danielcweeks (via GitHub)" <gi...@apache.org> on 2023/07/18 15:20:14 UTC
[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6906: Python: Add Google Cloud Storage support
danielcweeks commented on code in PR #6906:
URL: https://github.com/apache/iceberg/pull/6906#discussion_r1266935692
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -278,6 +279,15 @@ def _get_fs(self, scheme: str) -> FileSystem:
"region": self.properties.get(S3_REGION),
}
return S3FileSystem(**client_kwargs)
+ elif scheme in {"gs", "gcs"}:
+ if access_token := self.properties.get("gs.access-token"):
Review Comment:
I think this field should be `gs.token` based on the properties in the readme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org