You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2020/12/10 12:56:00 UTC

[jira] [Updated] (HDDS-4576) TestDefaultCertificateClient misuses chars param of random()

     [ https://issues.apache.org/jira/browse/HDDS-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Attila Doroszlai updated HDDS-4576:
-----------------------------------
    Description: 
{{TestDefaultCertificateClient}} passes "UTF-8" to {{RandomStringUtils.random(int, String)}} with the intention to use UTF-8 encoding.  It was added in HDDS-1087 to fix (intermittent?) failure in CI.

However, the parameter is not for character encoding, rather:

{code}
     * @param chars  the String containing the set of characters to use,
     *  may be null, but must not be empty
{code}

So this results in values like: {{"--8F8T8U8T..."}}.

  was:
{{TestDefaultCertificateClient}} passes "UTF-8" to {{RandomStringUtils.random(int, String)}} with the intention to use UTF-8 encoding.  It was added in HDDS-1087 to fix (intermittent?) failure in CI.

However, the parameter {{String chars}} is not for character encoding, rather the set of characters to generate the random string from.  So this results in values like: {{"--8F8T8U8T..."}}.


> TestDefaultCertificateClient misuses chars param of random()
> ------------------------------------------------------------
>
>                 Key: HDDS-4576
>                 URL: https://issues.apache.org/jira/browse/HDDS-4576
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Minor
>
> {{TestDefaultCertificateClient}} passes "UTF-8" to {{RandomStringUtils.random(int, String)}} with the intention to use UTF-8 encoding.  It was added in HDDS-1087 to fix (intermittent?) failure in CI.
> However, the parameter is not for character encoding, rather:
> {code}
>      * @param chars  the String containing the set of characters to use,
>      *  may be null, but must not be empty
> {code}
> So this results in values like: {{"--8F8T8U8T..."}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org