You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2018/04/17 20:17:00 UTC

[jira] [Created] (HBASE-20441) Add an HBase antipattern check for reintroducing commons-lang 2

Sean Busbey created HBASE-20441:
-----------------------------------

             Summary: Add an HBase antipattern check for reintroducing commons-lang 2
                 Key: HBASE-20441
                 URL: https://issues.apache.org/jira/browse/HBASE-20441
             Project: HBase
          Issue Type: Task
          Components: dependencies, test
    Affects Versions: 2.0.0
            Reporter: Sean Busbey
             Fix For: 2.0.1


We updated to commons-lang 3 in HBASE-18674 but we've regressed:

{code}
$ git grep org.apache.commons.lang\\.
hbase-common/src/main/java/org/apache/hadoop/hbase/net/Address.java:import org.apache.commons.lang.StringUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierFactoryImpl.java:import org.apache.commons.lang.builder.HashCodeBuilder;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import org.apache.commons.lang.builder.HashCodeBuilder;
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHdfsSnapshotHRegion.java:import org.apache.commons.lang.StringUtils;
hbase-server/src/test/java/org/apache/hadoop/hbase/util/compaction/TestMajorCompactionRequest.java:import org.apache.commons.lang.RandomStringUtils;
{code}

we should add the same kind of check as we do for e.g. hadoop annotations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)