You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2015/02/04 03:44:35 UTC

[jira] [Commented] (YARN-3058) Fix error message of tokens' activation delay configuration

    [ https://issues.apache.org/jira/browse/YARN-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304538#comment-14304538 ] 

Tsuyoshi OZAWA commented on YARN-3058:
--------------------------------------

Committing this to trunk and branch-2. Thanks [~hitliuyi] for your contribution!

> Fix error message of tokens' activation delay configuration
> -----------------------------------------------------------
>
>                 Key: YARN-3058
>                 URL: https://issues.apache.org/jira/browse/YARN-3058
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-3058.001.patch
>
>
> {code}
> this.rollingInterval = conf.getLong(
>          YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,
>         YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS) * 1000;
> ...
> this.activationDelay =
>         (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
>             YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
> ...
> if (rollingInterval <= activationDelay * 2) {
>       throw new IllegalArgumentException(
>           YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
>               + " should be more than 2 X "
>               + YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS);
>     }
> {code}
> The error msg should be 
> {code}
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
>               + " should be more than 3 X "
>               + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
> {code}
> Also It's {{3 X}} instead of {{2 X}}, since it's multiplied by *1.5*.
> There are few other places having same issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)