You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Tzvetanov Grigorov (Jira)" <ji...@apache.org> on 2022/01/21 10:22:00 UTC
[jira] [Commented] (WICKET-6947) IndicatingAjaxButton does not work with Bootstrap 4
[ https://issues.apache.org/jira/browse/WICKET-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479975#comment-17479975 ]
Martin Tzvetanov Grigorov commented on WICKET-6947:
---------------------------------------------------
Devs, how about this change:
{code:java}
iff --git wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 8d351f50b4..7eaa51a96e 100644
--- wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -1333,6 +1333,7 @@
} else {
e.style.display = display;
}
+ e.removeAttribute("hidden");
}
},
@@ -1341,6 +1342,7 @@
e = Wicket.$(e);
if (e !== null) {
jQuery(e).hide();
+ e.setAttribute("hidden", "");
}
},
{code}
My only doubt is: Should we always set hidden="" in Wicket.DOM.hide() ?
> IndicatingAjaxButton does not work with Bootstrap 4
> ---------------------------------------------------
>
> Key: WICKET-6947
> URL: https://issues.apache.org/jira/browse/WICKET-6947
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 9.5.0, 9.7.0
> Reporter: Michelle Ee
> Priority: Minor
> Attachments: Screenshot from 2022-01-21 09-04-51.png, wicket-test-1.0-SNAPSHOT.war, wicket-test.png, wicket-test.zip
>
>
> IndicatingAjaxButton's (and IndicatingAjaxLink's) indicator is not visible when using Bootstrap4.
> Since Wicket 9.x, the "hidden" attribute is added to the indicator element. When the indicating button is clicked, style="display:none" is appended to the element but "hidden" is not removed from the element.
> This poses a problem with Bootstrap 4 css
> [hidden] \{ display: none !important; }
--
This message was sent by Atlassian Jira
(v8.20.1#820001)