You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/14 17:11:50 UTC

[GitHub] [spark] tanelk commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions

tanelk commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708539248


   @maropu , I did the first steps, but I need some extra input.
   
   It seems, that the `sql-ref-functions-builtin.html` needs some redesign, for longer examples it looks quite bad: 
   ![2020-10-14-200649_1920x1080_scrot](https://user-images.githubusercontent.com/3342974/96022237-3ccedc00-0e59-11eb-947b-551a2b0cdde8.png)
   
   The one in SQL reference looks much better (although here is no grouping):
   ![2020-10-14-200728_1920x1080_scrot](https://user-images.githubusercontent.com/3342974/96022248-3fc9cc80-0e59-11eb-824e-56fc999d8b25.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org