[GitHub] [superset] diegomedina248 commented on a diff in pull request #20627: fix(chart): Time Series set showMaxLabel as null for time xAxis

[GitBox <gi...@apache.org>]

diegomedina248 commented on code in PR #20627:
URL: https://github.com/apache/superset/pull/20627#discussion_r915796625


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -326,13 +328,23 @@ export default function transformProps(
       rotate: xAxisLabelRotation,
     },
     minInterval:
-      xAxisType === 'time' && timeGrainSqla
+      xAxisType === AxisType.time && timeGrainSqla
         ? TIMEGRAIN_TO_TIMESTAMP[timeGrainSqla]
         : 0,
   };
+
+  if (xAxisType === AxisType.time) {
+    /**
+     * Overriding default behavior (false) for time axis regardless of the granilarity.
+     * Not including this in the initial declaration above so if echarts changes the default
+     * behavior for other axist types we won't unintentionally override it
+     */
+    xAxis = merge(xAxis, { axisLabel: { showMaxLabel: null } });

Review Comment:
   do we need the `merge` here? Seems like we're constructing a fresh object above, so maybe `xAxis.axisLabel.showLabel = null` is enough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org