[GitHub] [kyuubi] 531651225 commented on a diff in pull request #4000: [FEATURE] Support Apache Phoenix engine base on jdbc engine

[GitBox <gi...@apache.org>]

531651225 commented on code in PR #4000:
URL: https://github.com/apache/kyuubi/pull/4000#discussion_r1062033578


##########
pom.xml:
##########
@@ -169,6 +169,7 @@
         <ldapsdk.version>6.0.5</ldapsdk.version>
         <log4j.version>2.19.0</log4j.version>
         <mysql.jdbc.version>8.0.27</mysql.jdbc.version>
+        <phoenix.version>5.0.0-HBase-2.0</phoenix.version>

Review Comment:
   > I'm not familiar w/ phoenix ecosystem, the decision should be based on the client/server compatible matrix, and adoption rate of each project versions
   thanks your advice，Phoenix thin JDBC driver is backward compatible. Phoenix thin JDBC driver 6.xx is for integration test. When using kyuubi phoenix jdbc engine, users need to provide their own jdbc driver jar, copy to 'apache kyuubi xxx embedding bin/externals/engines/jdbc' directory, which is similar to kyuubi doris jdbc engine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org