You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:31:19 UTC
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #802: DISPATCH-960 Handle invalid configs when resolving port
jiridanek opened a new pull request #802:
URL: https://github.com/apache/qpid-dispatch/pull/802
The current implementation is failing with the tests in this PR in the following ways. The value `36875` is random (from reading uninitialized memory). CC @fgiorgetti
```
$ c_unittests -r=xml -ts=* -tc=test_qd_port_int
/home/jdanek/repos/qpid/qpid-dispatch/tests/c_unittests/test_amqp.cpp:32: Failure:
CHECK(qd_port_int("0") == 0)
with expansion:
36875 == 0
/home/jdanek/repos/qpid/qpid-dispatch/tests/c_unittests/test_amqp.cpp:44: Failure:
CHECK(qd_port_int("") == -1)
with expansion:
0 == -1
/home/jdanek/repos/qpid/qpid-dispatch/tests/c_unittests/test_amqp.cpp:46: Failure:
CHECK(qd_port_int("42http") == -1)
with expansion:
42 == -1
/home/jdanek/repos/qpid/qpid-dispatch/tests/c_unittests/test_amqp.cpp:47: Failure:
CHECK(qd_port_int("http42") == -1)
with expansion:
36875 == -1
/home/jdanek/repos/qpid/qpid-dispatch/tests/c_unittests/test_amqp.cpp:49: Failure:
CHECK(qd_port_int("no_such_port") == -1)
with expansion:
36875 == -1
Process finished with exit code 1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #802: DISPATCH-960 Handle invalid configs when resolving port
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #802:
URL: https://github.com/apache/qpid-dispatch/pull/802#issuecomment-666631020
I'm not super excited about how the patch turned out (looks way too complicated for the simple thing it is doing...) but if you think it is allright, I'll go ahead with it. And it passes the tests ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #802: DISPATCH-960 Handle invalid configs when resolving port
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #802:
URL: https://github.com/apache/qpid-dispatch/pull/802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org