You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "naivedogger (via GitHub)" <gi...@apache.org> on 2026/09/08 03:54:38 UTC
[PR] [c++] Avoid redundant copies during row type resolution [fluss]
naivedogger opened a new pull request, #4246:
URL: https://github.com/apache/fluss/pull/4246
## Summary
- Borrow unchanged STRING/BYTES values instead of deep-copying them during row type resolution.
- Preserve type conversions, validation, and nested row handling.
- Fixes apache/fluss#4239.
## Test Plan
- 4 regression tests passed.
- Cargo formatting and Clippy checks passed.
- Full Maven verification was blocked by an unrelated untracked file's license header.
🤖 AI-assisted changes - reviewed by human developer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [c++] Avoid redundant copies during row type resolution [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni merged PR #4246:
URL: https://github.com/apache/fluss/pull/4246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [c++] Avoid redundant copies during row type resolution [fluss]
Posted by "naivedogger (via GitHub)" <gi...@apache.org>.
naivedogger commented on PR #4246:
URL: https://github.com/apache/fluss/pull/4246#issuecomment-5714043325
Thanks for the review! Pushed a follow-up commit that does this. resolve_row_types now checks whether any column would actually change, i.e. an Int32 targeted at TinyInt or SmallInt, or a String targeted at Decimal, including inside nested rows. When nothing needs converting it returns the input row borrowed and no second row is built. Upsert and delete still pad short rows to full schema width, but a full-width row that needs no conversion now goes straight to the core writer.
The lookup paths got the same treatment: they compact and resolve in one pass, and when the PK or prefix values are already at dense positions with nothing to convert, the input row is used as-is. Validation behavior is unchanged, and the fast paths are covered by new tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org