You are viewing a plain text version of this content. The canonical link for it is here.
Posted to m2-dev@maven.apache.org by jv...@apache.org on 2004/09/17 05:05:07 UTC
cvs commit: maven-components/maven-core/src/main/java/org/apache/maven/project MavenProject.java
jvanzyl 2004/09/16 20:05:07
Modified: maven-core/src/main/java/org/apache/maven/project
MavenProject.java
Log:
o add a convenience method for the local repo path, the removal
of the properties broke a couple plugins using the local repo
property so i'll use this instead.
Revision Changes Path
1.7 +5 -0 maven-components/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
Index: MavenProject.java
===================================================================
RCS file: /home/cvs/maven-components/maven-core/src/main/java/org/apache/maven/project/MavenProject.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- MavenProject.java 15 Sep 2004 12:34:16 -0000 1.6
+++ MavenProject.java 17 Sep 2004 03:05:07 -0000 1.7
@@ -514,6 +514,11 @@
return model.getRepositories();
}
+ public String getLocalRepositoryPath()
+ {
+ return getLocalRepository().getBasedir();
+ }
+
public ArtifactRepository getLocalRepository()
{
if ( wagonLocalRepository == null && model.getLocal() != null && model.getLocal().getRepository() != null )
Re: cvs commit:
maven-components/maven-core/src/main/java/org/apache/maven/project
MavenProject.java
Posted by Jason van Zyl <jv...@maven.org>.
On Fri, 2004-09-17 at 09:34, Jason van Zyl wrote:
> On Fri, 2004-09-17 at 01:13, Brett Porter wrote:
> > I thought the plugins were using #maven.repo.local?
> >
> > I aliased that in the Ognl evaluator so that it still worked.
>
> Didn't work, but no biggy. I added the convenience method and changed
> the plugin I was working on.
I didn't qualify that: it was the removal of the properties that caused
the problem. In the idea plugin the MavenProject is brought in and I was
extracting the property directly from MavenProject. So what I was doing
needed to change.
I've started keeping track for what is valid as far as OGNL usage for
mojo parameters:
http://cvs.apache.org/viewcvs.cgi/maven-components/maven-core/docs/apt/mojos.apt?rev=1.2&view=auto
I really think the options can be severely limited as most default
values will come from the super model.
--
jvz.
Jason van Zyl
jason@maven.org
http://maven.apache.org
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
Re: cvs commit:
maven-components/maven-core/src/main/java/org/apache/maven/project
MavenProject.java
Posted by Jason van Zyl <jv...@maven.org>.
On Fri, 2004-09-17 at 01:13, Brett Porter wrote:
> I thought the plugins were using #maven.repo.local?
>
> I aliased that in the Ognl evaluator so that it still worked.
Didn't work, but no biggy. I added the convenience method and changed
the plugin I was working on.
> Anyway, I do have a note to self to resolve the differences. Would be nice just
> to have one of these and use it across all the plugins.
>
> - Brett
>
> Quoting "jvanzyl@apache.org" <jv...@apache.org>:
>
> > jvanzyl 2004/09/16 20:05:07
> >
> > Modified: maven-core/src/main/java/org/apache/maven/project
> > MavenProject.java
> > Log:
> > o add a convenience method for the local repo path, the removal
> > of the properties broke a couple plugins using the local repo
> > property so i'll use this instead.
> >
> > Revision Changes Path
> > 1.7 +5 -0
> >
> maven-components/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
> >
> > Index: MavenProject.java
> > ===================================================================
> > RCS file:
> >
> /home/cvs/maven-components/maven-core/src/main/java/org/apache/maven/project/MavenProject.java,v
> > retrieving revision 1.6
> > retrieving revision 1.7
> > diff -u -r1.6 -r1.7
> > --- MavenProject.java 15 Sep 2004 12:34:16 -0000 1.6
> > +++ MavenProject.java 17 Sep 2004 03:05:07 -0000 1.7
> > @@ -514,6 +514,11 @@
> > return model.getRepositories();
> > }
> >
> > + public String getLocalRepositoryPath()
> > + {
> > + return getLocalRepository().getBasedir();
> > + }
> > +
> > public ArtifactRepository getLocalRepository()
> > {
> > if ( wagonLocalRepository == null && model.getLocal() != null &&
> > model.getLocal().getRepository() != null )
> >
> >
> >
> >
--
jvz.
Jason van Zyl
jason@maven.org
http://maven.apache.org
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
Re: cvs commit: maven-components/maven-core/src/main/java/org/apache/maven/project MavenProject.java
Posted by Brett Porter <br...@apache.org>.
I thought the plugins were using #maven.repo.local?
I aliased that in the Ognl evaluator so that it still worked.
Anyway, I do have a note to self to resolve the differences. Would be nice just
to have one of these and use it across all the plugins.
- Brett
Quoting "jvanzyl@apache.org" <jv...@apache.org>:
> jvanzyl 2004/09/16 20:05:07
>
> Modified: maven-core/src/main/java/org/apache/maven/project
> MavenProject.java
> Log:
> o add a convenience method for the local repo path, the removal
> of the properties broke a couple plugins using the local repo
> property so i'll use this instead.
>
> Revision Changes Path
> 1.7 +5 -0
>
maven-components/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
>
> Index: MavenProject.java
> ===================================================================
> RCS file:
>
/home/cvs/maven-components/maven-core/src/main/java/org/apache/maven/project/MavenProject.java,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- MavenProject.java 15 Sep 2004 12:34:16 -0000 1.6
> +++ MavenProject.java 17 Sep 2004 03:05:07 -0000 1.7
> @@ -514,6 +514,11 @@
> return model.getRepositories();
> }
>
> + public String getLocalRepositoryPath()
> + {
> + return getLocalRepository().getBasedir();
> + }
> +
> public ArtifactRepository getLocalRepository()
> {
> if ( wagonLocalRepository == null && model.getLocal() != null &&
> model.getLocal().getRepository() != null )
>
>
>
>