You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tanmayrauth (via GitHub)" <gi...@apache.org> on 2026/06/23 23:48:59 UTC
[PR] Make scan_plan_helper internal (#3541) [iceberg-python]
tanmayrauth opened a new pull request, #3553:
URL: https://github.com/apache/iceberg-python/pull/3553
scan_plan_helper is an internal helper for local scan planning, not a public extension point. Rename it to _scan_plan_helper to reflect its intended visibility and update its only caller in inspect.py.
The method was introduced recently in d99936a and has not been part of any released public API, so no deprecation shim is required.
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
## Are these changes tested?
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make scan_plan_helper internal (#3541) [iceberg-python]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on PR #3553:
URL: https://github.com/apache/iceberg-python/pull/3553#issuecomment-4784575393
> Fixes: https://github.com/apache/iceberg-python/pull/3451
I think the right issue number is `#3541`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make scan_plan_helper internal (#3541) [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #3553:
URL: https://github.com/apache/iceberg-python/pull/3553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make scan_plan_helper internal (#3541) [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #3553:
URL: https://github.com/apache/iceberg-python/pull/3553#discussion_r3488431989
##########
pyiceberg/table/__init__.py:
##########
@@ -2110,7 +2110,7 @@ def _manifest_planner(self) -> ManifestGroupPlanner:
def partition_filters(self) -> KeyDefaultDict[int, BooleanExpression]:
return self._manifest_planner.partition_filters
- def scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
+ def _scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
Review Comment:
Let's make it internal first, we can always change the name then :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make scan_plan_helper internal (#3541) [iceberg-python]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #3553:
URL: https://github.com/apache/iceberg-python/pull/3553#discussion_r3464528376
##########
pyiceberg/table/__init__.py:
##########
@@ -2110,7 +2110,7 @@ def _manifest_planner(self) -> ManifestGroupPlanner:
def partition_filters(self) -> KeyDefaultDict[int, BooleanExpression]:
return self._manifest_planner.partition_filters
- def scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
+ def _scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
Review Comment:
nit: I feel `_helper` suffix is weird. The name should describe what it does, not that it's a helper. We could rename it to `_plan_manifest_entries` or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org