You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/07 18:11:25 UTC
[GitHub] [incubator-superset] riahk commented on a change in pull request #10526: feat: SIP-34 card/grid views for dashboards and charts
riahk commented on a change in pull request #10526:
URL: https://github.com/apache/incubator-superset/pull/10526#discussion_r466680815
##########
File path: superset-frontend/src/components/FaveStar.tsx
##########
@@ -59,7 +60,7 @@ export default class FaveStar extends React.PureComponent<FaveStarProps> {
? 'favorite-selected'
: 'favorite-unselected'
}
- viewBox="0 0 16 15"
+ viewBox={this.props.viewBox || '0 0 16 16'}
Review comment:
Why the change here? The previous `viewBox` matches the prop on the svg itself, unless we want to update that one as well.
##########
File path: superset-frontend/src/components/Icon/index.tsx
##########
@@ -64,7 +66,9 @@ type IconName =
| 'sort-desc'
| 'trash'
| 'share'
- | 'warning';
+ | 'warning'
+ | 'list-view'
+ | 'card-view';
Review comment:
v small nit but let's keep this list (and the one below) alphabetical
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org