You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/02/25 03:29:56 UTC

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #503: OAK-9705 Explain Query tool doesn't show the correct ES query when su…

nit0906 commented on a change in pull request #503:
URL: https://github.com/apache/jackrabbit-oak/pull/503#discussion_r814449106



##########
File path: oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticSuggestQueryTest.java
##########
@@ -0,0 +1,122 @@
+/*

Review comment:
       There's a test class for suggest use cases - IndexSuggestionCommonTest which is extended by ElasticIndexSuggestionCommonTest and LuceneIndexSuggestionCommonTest. Maybe we can add new tests there only - this way it's easier to maintain - also we do similar tests for both lucene and elastic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org