You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:08:58 UTC

[GitHub] [beam] robertwb commented on a change in pull request #14908: [BEAM-9547] Add support for argsort

robertwb commented on a change in pull request #14908:
URL: https://github.com/apache/beam/pull/14908#discussion_r649623968



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1541,6 +1541,19 @@ def repeat(self, repeats, axis):
           "repeat(repeats=) value must be an int or a "
           f"DeferredSeries (encountered {type(repeats)}).")
 
+  @frame_base.with_docs_from(pd.Series)

Review comment:
       The docs seem sparse on this one, can you add a manual test? (Granted, the implementation is trivial with now, but if this TODO is addressed it'd be nice if existing tests caught anything that went wrong.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org