You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/10/20 06:47:53 UTC
[PR] CAMEL-25820: LogConfigurationTest starts without the log directory property that another test may have left [camel]
davsclaus opened a new pull request, #28146:
URL: https://github.com/apache/camel/pull/28146
Follow-up of [CAMEL-25820](https://issues.apache.org/jira/browse/CAMEL-25820) (#28113): `LogConfigurationTest.withoutTheDirectoryOfTheCliTheLogFileIsInTheCamelDirectoryOfTheUser` failed in a full run of camel-jbang-core, depending on the order of the tests:
```
expected: ".../camel-jbang-core/target/test-home-2/.camel/84499.log"
but was: "/var/folders/.../junit-10245052296718260853/.camel/84499.log"
```
The tests of camel-jbang-core run in reused forks. A test of a command that configured the logging (`RuntimeUtil.configureLog`, as the CLI does) leaves `camel.jbang.logDir` set to the Camel directory of its own temp home. The test class cleared the property after each of its tests, but not before the first one.
- Each test of `LogConfigurationTest` now starts without the property.
## Tests
- Reproduced with a throwaway test class that leaves the property set, run before `LogConfigurationTest` in one fork (`-Dsurefire.runOrder=alphabetical -Dcamel.surefire.forkCount=1`): without the change, the same failure; with it, all 7 tests pass. The throwaway class is not part of the PR.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25820: LogConfigurationTest starts without the log directory property that another test may have left [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #28146:
URL: https://github.com/apache/camel/pull/28146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25820: LogConfigurationTest starts without the log directory property that another test may have left [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28146:
URL: https://github.com/apache/camel/pull/28146#issuecomment-6285536818
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-core`
:repeat: **1 test passed only after a retry on JDK 25** (1 retried attempt)
<details><summary>Recovered flaky tests on JDK 25 (1)</summary>
| Module | Test | Failed attempts | First failure |
| --- | --- | --- | --- |
| `dsl/camel-jbang/camel-jbang-plugin-tui` | `LaunchManagerOutcomeTest.startedWhenTheStatusFileSaysSo` | 1 | expected: null but was: LaunchOutcome[ok=false, log=null] |
> :information_source: These tests did **not** fail the build. Surefire retried them and they passed.
> Retries are enabled project-wide by `surefire.rerunFailingTestsCount` in `parent/pom.xml`.
</details>
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 0 of 707 tested, 0 compile-only — current: 5 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **0 affected modules** (current approach: 5).
**Skip-tests mode would test 0 modules** (1 direct + 0 downstream), **skip tests for 0** (generated code, meta-modules)
<details><summary>Modules only in current approach (5)</summary>
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-launcher-container`
</details>
<details><summary>Modules Scalpel would test (0)</summary>
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `dsl/camel-jbang/camel-jbang-core`: 2 test(s) disabled on GitHub Actions
:bulb: **Manual integration tests recommended:**
> You modified `dsl/camel-jbang/camel-jbang-core`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually:
> ```
> mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
> ```
<details><summary>All tested modules (6 modules, 1m 4s total)</summary>
**Total reactor time:** 1m 4s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: JBang :: MCP | 31.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 29.2s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 2.9s | SUCCESS |
| Camel :: JBang :: Core | n/a | |
| Camel :: JBang :: Plugin :: TUI | n/a | |
| Camel :: Launcher :: Container | n/a | |
**Top 20 slowest modules:**
- `Camel :: JBang :: MCP` (31.6s)
- `Camel :: JBang :: Plugin :: Validate` (29.2s)
- `Camel :: JBang :: Plugin :: MCP` (2.9s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/39382487535)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25820: LogConfigurationTest starts without the log directory property that another test may have left [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28146:
URL: https://github.com/apache/camel/pull/28146#issuecomment-6285148140
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org