You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/10 07:43:24 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #38583: [SPARK-41092][SQL] Do not use identifier to match interval units

cloud-fan commented on code in PR #38583:
URL: https://github.com/apache/spark/pull/38583#discussion_r1018745916


##########
docs/sql-ref-ansi-compliance.md:
##########
@@ -407,6 +407,7 @@ Below is a list of all the keywords in Spark SQL.
 |DATEADD|non-reserved|non-reserved|non-reserved|
 |DATEDIFF|non-reserved|non-reserved|non-reserved|
 |DAY|non-reserved|non-reserved|non-reserved|
+|DAYS|non-reserved|non-reserved|non-reserved|

Review Comment:
   it's not a new feature. `InternalUtils.stringToInterval` allows ending `s` in unit names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org