You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/23 23:40:58 UTC
[GitHub] [incubator-mxnet] ptrendx opened a new pull request #20212: [BUGFIX] Fix workspace of BoxNMS
ptrendx opened a new pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212
## Description ##
This commit fixes 2 problems:
- previously in the calculation of the workspace size of NMS operator the space for the buffer was not included, resulting in potentially too small allocation
- because the type requested for `uint8_t`, the maximum workspace size without setting large tensor support was 2GB, which was too small for some cases, without any error reporting (going over that limit would make the index_t in Shape1 overflow, resulting in negative value, which would later be cast to size_t in the allocator and MXNet would try to allocate a huge amount of memory, resulting in OoM). This PR changes the type of the allocation to double so that the size limit for workspace rises to 16 GB when large tensor support is not enabled.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-825994052
Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, clang, centos-gpu, centos-cpu, windows-gpu, miscellaneous, unix-cpu, windows-cpu, edge, website, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826030921
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826984312
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826502150
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826502126
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826984250
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826030912
@mxnet-bot run ci [centos-cpu, centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826502150
Jenkins CI successfully triggered : [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 merged pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
DickJC123 merged pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20212: [BUGFIX] Fix workspace of BoxNMS
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20212:
URL: https://github.com/apache/incubator-mxnet/pull/20212#issuecomment-826502126
@mxnet-bot run ci [centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org