You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by an...@apache.org on 2014/10/24 07:24:35 UTC

git commit: PHOENIX-910 Filter should override hasFilterRow() when filterRow() is overridden.(Ted)

Repository: phoenix
Updated Branches:
  refs/heads/master fba06a80f -> 06a511cff


PHOENIX-910 Filter should override hasFilterRow() when filterRow() is overridden.(Ted)


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/06a511cf
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/06a511cf
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/06a511cf

Branch: refs/heads/master
Commit: 06a511cffe2e04bf85db3d7fa6ade8327ee24cd6
Parents: fba06a8
Author: anoopsjohn <an...@gmail.com>
Authored: Fri Oct 24 10:54:12 2014 +0530
Committer: anoopsjohn <an...@gmail.com>
Committed: Fri Oct 24 10:54:12 2014 +0530

----------------------------------------------------------------------
 .../org/apache/phoenix/filter/BooleanExpressionFilter.java     | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/06a511cf/phoenix-core/src/main/java/org/apache/phoenix/filter/BooleanExpressionFilter.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/filter/BooleanExpressionFilter.java b/phoenix-core/src/main/java/org/apache/phoenix/filter/BooleanExpressionFilter.java
index e0caf9f..c5b36b2 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/filter/BooleanExpressionFilter.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/filter/BooleanExpressionFilter.java
@@ -37,6 +37,7 @@ import org.apache.phoenix.util.ServerUtil;
  * 
  * Base class for filter that evaluates a WHERE clause expression.
  *
+ * Subclass is expected to implement filterRow() method
  * 
  * @since 0.1
  */
@@ -57,6 +58,11 @@ abstract public class BooleanExpressionFilter extends FilterBase implements Writ
     }
     
     @Override
+    public boolean hasFilterRow() {
+      return true;
+    }
+
+    @Override
     public int hashCode() {
         final int prime = 31;
         int result = 1;