You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "freedev (via GitHub)" <gi...@apache.org> on 2024/01/16 17:03:44 UTC
[PR] SOLR-17074 - Not correctly escaped quote in bin/solr script [solr]
freedev opened a new pull request, #2200:
URL: https://github.com/apache/solr/pull/2200
https://issues.apache.org/jira/browse/SOLR-17074
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
fixed the script `solr/bin/solr`
# Solution
Added the missing quotes
# Tests
Tried to run the script locally, now the output is correct.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17074 - Not correctly escaped quote in bin/solr script [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke merged PR #2200:
URL: https://github.com/apache/solr/pull/2200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17074 - Not correctly escaped quote in bin/solr script [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #2200:
URL: https://github.com/apache/solr/pull/2200#discussion_r1453726936
##########
solr/bin/solr:
##########
@@ -422,7 +422,7 @@ function print_usage() {
echo ""
echo " -noprompt Don't prompt for input; accept all defaults when running examples that accept user input"
echo ""
- echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as "root" can cause problems."
+ echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as \"root\" can cause problems."
echo " It is possible to override this warning with the `-force` parameter."
Review Comment:
```suggestion
echo " It is possible to override this warning with the '-force' parameter."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17074 - Not correctly escaped quote in bin/solr script [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #2200:
URL: https://github.com/apache/solr/pull/2200#discussion_r1457790607
##########
solr/CHANGES.txt:
##########
@@ -174,6 +174,8 @@ Bug Fixes
* SOLR-16203: Properly initialize schema plugins loaded by SPI name (janhoy, hossman, Uwe Schindler)
+* SOLR-17074: Fixed not correctly escaped quote in bin/solr script (Dominique Béjean, Vincenzo D'Amore)
+
Review Comment:
Thanks @freedev for iterating on this pull request! I've moved the entry to the 9.5 section here and added attribution for both yourself and Dominique as reporter of the issue.
Please let us know if you'd prefer a different attribution e.g. see line 175 above, some folks use their handle and others their name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17074 - Not correctly escaped quote in bin/solr script [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2200:
URL: https://github.com/apache/solr/pull/2200#discussion_r1453760994
##########
solr/bin/solr:
##########
@@ -422,7 +422,7 @@ function print_usage() {
echo ""
echo " -noprompt Don't prompt for input; accept all defaults when running examples that accept user input"
echo ""
- echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as "root" can cause problems."
+ echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as \"root\" can cause problems."
echo " It is possible to override this warning with the `-force` parameter."
Review Comment:
i like this change..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17074 - Not correctly escaped quote in bin/solr script [solr]
Posted by "freedev (via GitHub)" <gi...@apache.org>.
freedev commented on code in PR #2200:
URL: https://github.com/apache/solr/pull/2200#discussion_r1457696931
##########
solr/bin/solr:
##########
@@ -422,7 +422,7 @@ function print_usage() {
echo ""
echo " -noprompt Don't prompt for input; accept all defaults when running examples that accept user input"
echo ""
- echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as "root" can cause problems."
+ echo " -force If attempting to start Solr as the root user, the script will exit with a warning that running Solr as \"root\" can cause problems."
echo " It is possible to override this warning with the `-force` parameter."
Review Comment:
I've added in my PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org