You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/07/14 03:51:37 UTC

[jira] [Commented] (HDFS-3659) add the missed @Override to methods

    [ https://issues.apache.org/jira/browse/HDFS-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414252#comment-13414252 ] 

Hadoop QA commented on HDFS-3659:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12536475/HDFS-3659.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 50 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.TestBackupNode
                  org.apache.hadoop.hdfs.server.common.TestJspHelper

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2820//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2820//console

This message is automatically generated.
                
> add  the missed @Override to methods
> ------------------------------------
>
>                 Key: HDFS-3659
>                 URL: https://issues.apache.org/jira/browse/HDFS-3659
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-3659.patch
>
>
> Adding @Override to the proper methods to take advantage of the compiler checking and make the code more readable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira