You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/02/07 22:44:00 UTC

[jira] [Created] (HBASE-19954) ShutdownHook should check whether shutdown hook is tracked by ShutdownHookManager

Ted Yu created HBASE-19954:
------------------------------

             Summary: ShutdownHook should check whether shutdown hook is tracked by ShutdownHookManager
                 Key: HBASE-19954
                 URL: https://issues.apache.org/jira/browse/HBASE-19954
             Project: HBase
          Issue Type: Bug
            Reporter: Ted Yu
            Assignee: Ted Yu


Currently ShutdownHook#suppressHdfsShutdownHook() does the following:
{code}
      synchronized (fsShutdownHooks) {
        boolean isFSCacheDisabled = fs.getConf().getBoolean("fs.hdfs.impl.disable.cache", false);
        if (!isFSCacheDisabled && !fsShutdownHooks.containsKey(hdfsClientFinalizer)
            && !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) {
{code}
There is no check that ShutdownHookManager still tracks the shutdown hook, leading to potential RuntimeException (as can be observed in hadoop3 Jenkins job).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)