You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Matthias Wessendorf <ma...@apache.org> on 2007/04/19 09:28:30 UTC
MessageBundleTest._validateBundleParams
Hi,
when putting the *new* messages in place, I noticed that this test fails:
MessageBundleTest._validateBundleParams()
That is because only the English messages are in a "good shape", all
translations, like German, Chinese and whatnot aren't updated yet.
Two possible steps I am seeing:
-commit all in once (English and translated)
-turn off the test (for now ;-))
What is your take on that?
Thx,
Matthias
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: MessageBundleTest._validateBundleParams
Posted by Matthias Wessendorf <ma...@apache.org>.
That is my guess as well,
at least before disabling a test, I need to ask the group ;-)
Thanks,
Matthias
On 4/20/07, Adam Winer <aw...@gmail.com> wrote:
> Ah, I see. It gives warnings for missing keys, but errors
> when the set of parameters don't match up. Yeah,
> I guess disabling it is the simplest answer.
>
> -- Adam
>
>
> On 4/19/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > It fails
> >
> > Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0,031 sec
> >
> > testBundles(org.apache.myfaces.trinidad.resource.MessageBundleTest)
> > Time elapsed: 0,031 sec <<< FAILURE!
> >
> > [ stdout ] ---------------------------------------------------------------
> >
> >
> >
> > [ stderr ] ---------------------------------------------------------------
> >
> >
> >
> > [ stacktrace ] -----------------------------------------------------------
> >
> > junit.framework.AssertionFailedError: Error while testing bundle
> > MessageBundle_ar
> > Place holders mismatch in key
> > org.apache.myfaces.trinidad.validator.DateTimeRangeValidator.MAXIMUM_detail
> > Default bundle params {2}
> > MessageBundle_ar params {2} {1}
> > at junit.framework.Assert.fail(Assert.java:47)
> > at org.apache.myfaces.trinidad.resource.MessageBundleTest._validateBundleParams(MessageBundleTest.java:237)
> > at org.apache.myfaces.trinidad.resource.MessageBundleTest._validateBundle(MessageBundleTest.java:142)
> >
> >
> > Do you mind to disable it for now ?
> > I'll file a bug that it's disabled, I'll enable it, when the
> > translations arrive.
> >
> >
> >
> > On 4/19/07, Adam Winer <aw...@gmail.com> wrote:
> > > I think the test should just be dumping warnings, not failing.
> > >
> > > -- Adam
> > >
> > >
> > > On 4/19/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > >
> > > > Hi,
> > > >
> > > > when putting the *new* messages in place, I noticed that this test fails:
> > > > MessageBundleTest._validateBundleParams()
> > > >
> > > > That is because only the English messages are in a "good shape", all
> > > > translations, like German, Chinese and whatnot aren't updated yet.
> > > >
> > > > Two possible steps I am seeing:
> > > > -commit all in once (English and translated)
> > > > -turn off the test (for now ;-))
> > > >
> > > > What is your take on that?
> > > >
> > > > Thx,
> > > > Matthias
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: MessageBundleTest._validateBundleParams
Posted by Adam Winer <aw...@gmail.com>.
Ah, I see. It gives warnings for missing keys, but errors
when the set of parameters don't match up. Yeah,
I guess disabling it is the simplest answer.
-- Adam
On 4/19/07, Matthias Wessendorf <ma...@apache.org> wrote:
> It fails
>
> Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0,031 sec
>
> testBundles(org.apache.myfaces.trinidad.resource.MessageBundleTest)
> Time elapsed: 0,031 sec <<< FAILURE!
>
> [ stdout ] ---------------------------------------------------------------
>
>
>
> [ stderr ] ---------------------------------------------------------------
>
>
>
> [ stacktrace ] -----------------------------------------------------------
>
> junit.framework.AssertionFailedError: Error while testing bundle
> MessageBundle_ar
> Place holders mismatch in key
> org.apache.myfaces.trinidad.validator.DateTimeRangeValidator.MAXIMUM_detail
> Default bundle params {2}
> MessageBundle_ar params {2} {1}
> at junit.framework.Assert.fail(Assert.java:47)
> at org.apache.myfaces.trinidad.resource.MessageBundleTest._validateBundleParams(MessageBundleTest.java:237)
> at org.apache.myfaces.trinidad.resource.MessageBundleTest._validateBundle(MessageBundleTest.java:142)
>
>
> Do you mind to disable it for now ?
> I'll file a bug that it's disabled, I'll enable it, when the
> translations arrive.
>
>
>
> On 4/19/07, Adam Winer <aw...@gmail.com> wrote:
> > I think the test should just be dumping warnings, not failing.
> >
> > -- Adam
> >
> >
> > On 4/19/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > >
> > > Hi,
> > >
> > > when putting the *new* messages in place, I noticed that this test fails:
> > > MessageBundleTest._validateBundleParams()
> > >
> > > That is because only the English messages are in a "good shape", all
> > > translations, like German, Chinese and whatnot aren't updated yet.
> > >
> > > Two possible steps I am seeing:
> > > -commit all in once (English and translated)
> > > -turn off the test (for now ;-))
> > >
> > > What is your take on that?
> > >
> > > Thx,
> > > Matthias
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>
Re: MessageBundleTest._validateBundleParams
Posted by Matthias Wessendorf <ma...@apache.org>.
It fails
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0,031 sec
testBundles(org.apache.myfaces.trinidad.resource.MessageBundleTest)
Time elapsed: 0,031 sec <<< FAILURE!
[ stdout ] ---------------------------------------------------------------
[ stderr ] ---------------------------------------------------------------
[ stacktrace ] -----------------------------------------------------------
junit.framework.AssertionFailedError: Error while testing bundle
MessageBundle_ar
Place holders mismatch in key
org.apache.myfaces.trinidad.validator.DateTimeRangeValidator.MAXIMUM_detail
Default bundle params {2}
MessageBundle_ar params {2} {1}
at junit.framework.Assert.fail(Assert.java:47)
at org.apache.myfaces.trinidad.resource.MessageBundleTest._validateBundleParams(MessageBundleTest.java:237)
at org.apache.myfaces.trinidad.resource.MessageBundleTest._validateBundle(MessageBundleTest.java:142)
Do you mind to disable it for now ?
I'll file a bug that it's disabled, I'll enable it, when the
translations arrive.
On 4/19/07, Adam Winer <aw...@gmail.com> wrote:
> I think the test should just be dumping warnings, not failing.
>
> -- Adam
>
>
> On 4/19/07, Matthias Wessendorf <ma...@apache.org> wrote:
> >
> > Hi,
> >
> > when putting the *new* messages in place, I noticed that this test fails:
> > MessageBundleTest._validateBundleParams()
> >
> > That is because only the English messages are in a "good shape", all
> > translations, like German, Chinese and whatnot aren't updated yet.
> >
> > Two possible steps I am seeing:
> > -commit all in once (English and translated)
> > -turn off the test (for now ;-))
> >
> > What is your take on that?
> >
> > Thx,
> > Matthias
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
--
Matthias Wessendorf
http://tinyurl.com/fmywh
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: MessageBundleTest._validateBundleParams
Posted by Adam Winer <aw...@gmail.com>.
I think the test should just be dumping warnings, not failing.
-- Adam
On 4/19/07, Matthias Wessendorf <ma...@apache.org> wrote:
>
> Hi,
>
> when putting the *new* messages in place, I noticed that this test fails:
> MessageBundleTest._validateBundleParams()
>
> That is because only the English messages are in a "good shape", all
> translations, like German, Chinese and whatnot aren't updated yet.
>
> Two possible steps I am seeing:
> -commit all in once (English and translated)
> -turn off the test (for now ;-))
>
> What is your take on that?
>
> Thx,
> Matthias
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>