You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/13 01:16:07 UTC

[GitHub] [flink-connector-jdbc] EchoLee5 opened a new pull request, #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

EchoLee5 opened a new pull request, #5:
URL: https://github.com/apache/flink-connector-jdbc/pull/5

   Fix the problem of JdbcOutputFormat database connection leak


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #5:
URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-1347608547

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-jdbc] EchoLee5 commented on pull request #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

Posted by GitBox <gi...@apache.org>.
EchoLee5 commented on PR #5:
URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-1352588573

   > @EchoLee5 Thanks for the PR, is it possible to add a test for this?
   
   I have added test cases, please help me review the code again, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #5:
URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-1561750113

   @EchoLee5 Can you please rebase and use the new testing setup?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-jdbc] KevDi commented on pull request #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

Posted by "KevDi (via GitHub)" <gi...@apache.org>.
KevDi commented on PR #5:
URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-1653537091

   @MartijnVisser is there any update on this PR? I can also open a new PR with the fixes from @EchoLee5. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org